Skip to content

fix(provider): name DeepSeek in provider help text#2366

Open
reidliu41 wants to merge 1 commit into
Hmbown:mainfrom
reidliu41:fix/provider-description-deepseek
Open

fix(provider): name DeepSeek in provider help text#2366
reidliu41 wants to merge 1 commit into
Hmbown:mainfrom
reidliu41:fix/provider-description-deepseek

Conversation

@reidliu41
Copy link
Copy Markdown
Contributor

@reidliu41 reidliu41 commented May 29, 2026

Summary

Fixes #2363.

/provider help and completion text described the active LLM backend options as:

codewhale | nvidia-nim | ollama

That is confusing because codewhale is the app name, not a provider id accepted by /provider. The actual provider id is deepseek.

This updates the shipped locale descriptions to show:

deepseek | nvidia-nim | ollama

and adds a regression test so the provider help text does not drift back to naming codewhale as a backend.

image

Testing

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features
  • cargo test --workspace --all-features

Checklist

  • Updated docs or comments as needed
  • Added or updated tests where relevant
  • Verified TUI behavior manually if UI changes

Greptile Summary

Corrects a mislabeled provider name in the /provider command help text: the app name "codewhale" was incorrectly listed as a backend identifier in place of the actual provider id "deepseek". The fix is applied to all five actively translated locales (English, Japanese, Simplified Chinese, Brazilian Portuguese, Latin American Spanish); Traditional Chinese inherits the correction through its existing fallback to Simplified Chinese.

  • Renames codewhaledeepseek in CmdProviderDescription across all locale functions in localization.rs.
  • Adds a provider_description_names_deepseek_backend test that iterates Locale::shipped() and asserts the text contains "deepseek" and does not contain "codewhale |".

Confidence Score: 5/5

Safe to merge — purely a string correction in locale help text with no logic changes and a new regression test.

All six shipped locales now show the correct provider id; Traditional Chinese inherits the fix through its fallback. The new test covers every locale. The only observation is a minor gap in the negative assertion pattern, which does not affect correctness today.

No files require special attention.

Important Files Changed

Filename Overview
crates/tui/src/localization.rs Replaces "codewhale" with "deepseek" in CmdProviderDescription across all 5 translated locales (en, ja, zh-Hans, pt-BR, es-419), with ZhHant inheriting the zh-Hans fix via its existing fallback chain; adds a regression test covering all shipped locales.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["tr(locale, CmdProviderDescription)"] --> B{locale}
    B -->|En| C["english() → 'deepseek | nvidia-nim | ollama'"]
    B -->|Ja| D["japanese() → 'deepseek | nvidia-nim | ollama'"]
    B -->|ZhHans| E["chinese_simplified() → 'deepseek | nvidia-nim | ollama'"]
    B -->|ZhHant| F["traditional_chinese()"]
    F -->|CmdProviderDescription not overridden| E
    B -->|PtBr| G["portuguese_brazil() → 'deepseek | nvidia-nim | ollama'"]
    B -->|Es419| H["spanish_latin_america() → 'deepseek | nvidia-nim | ollama'"]
    C & D & E & G & H --> I["Regression test: contains 'deepseek' ✓\nnot contains 'codewhale |' ✓"]
Loading

Fix All in Codex Fix All in Claude Code Fix All in Cursor

Reviews (1): Last reviewed commit: "fix(provider): name DeepSeek in provider..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

  Replace the incorrect CodeWhale backend example in /provider help text with DeepSeek.

  CodeWhale is the app name, while deepseek is the actual provider id accepted by /provider.
  Add a regression test for shipped locale descriptions.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the localization files to replace references to the "codewhale" LLM backend with "deepseek" across multiple languages, and adds a corresponding unit test. The review feedback suggests a more robust assertion in the new unit test to ensure "codewhale" is completely excluded, rather than just checking for "codewhale |", which could be bypassed if formatting changes.

Comment on lines +2782 to +2786
assert!(
!description.contains("codewhale |"),
"{} provider description should not name codewhale as a backend: {description}",
locale.tag()
);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The assertion checks for !description.contains("codewhale |"). If a future translation or update changes the separator (e.g., using commas or slashes like codewhale / nvidia-nim), this test would fail to detect the presence of codewhale. It is safer and more robust to assert !description.contains("codewhale") to completely prevent the backend description from referencing codewhale.

Suggested change
assert!(
!description.contains("codewhale |"),
"{} provider description should not name codewhale as a backend: {description}",
locale.tag()
);
assert!(
!description.contains("codewhale"),
"{} provider description should not name codewhale as a backend: {description}",
locale.tag()
);

Comment on lines +2777 to +2783
assert!(
description.contains("deepseek"),
"{} provider description should mention deepseek: {description}",
locale.tag()
);
assert!(
!description.contains("codewhale |"),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Negative assertion may be too narrow to catch future regressions

The guard !description.contains("codewhale |") requires both the name and a trailing space + pipe to match, so a typo like "codewhale|" or just "codewhale" would slip past it silently. Checking !description.contains("codewhale") (without the pipe) would be a stricter backstop against any form of the wrong name reappearing in this string.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Codex Fix in Claude Code Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/provider description refers to LLM provider as codewhale rather than deepseek

1 participant