test(shell): cover tty controlling terminal

[Hmbown]

Summary

• harvests test(shell): cover tty controlling terminal #2408 with credit to @axobase001
• adds a Unix regression test for tty=true background shell jobs opening /dev/tty
• exercises the same shell-manager path used by task_shell_start with DangerFullAccess, so controlling-terminal setup failures are caught in CI
• gives the get_output wait window extra margin so the test is less brittle on loaded runners

Partially addresses #2372

Validation

• cargo fmt --all -- --check
• git diff --check
• CARGO_TARGET_DIR=/Volumes/VIXinSSD/codewhale-pr2408-target cargo test -p codewhale-tui --bin codewhale-tui background_tty_command_has_controlling_terminal --locked -- --nocapture
• CARGO_TARGET_DIR=/Volumes/VIXinSSD/codewhale-pr2408-check-target cargo check -p codewhale-tui --locked

[greptile-apps]

Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[gemini-code-assist]

Code Review

This pull request adds a new Unix-specific test, background_tty_command_has_controlling_terminal, to crates/tui/src/tools/shell/tests.rs. The test verifies that background commands executed via the shell manager have access to a controlling terminal by opening /dev/tty and asserting that the command completes successfully with the expected output. There are no review comments, and I have no additional feedback to provide.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.