Skip to content

docs(protocol): add doc comments to all public types#2458

Merged
Hmbown merged 4 commits into
Hmbown:mainfrom
HUQIANTAO:docs/protocol-crate-docs
May 31, 2026
Merged

docs(protocol): add doc comments to all public types#2458
Hmbown merged 4 commits into
Hmbown:mainfrom
HUQIANTAO:docs/protocol-crate-docs

Conversation

@HUQIANTAO
Copy link
Copy Markdown
Contributor

Add doc comments to all public types in the protocol crate, covering all request/response types, event frames, tool payloads, and approval model.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUQIANTAO has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUQIANTAO has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@Hmbown
Copy link
Copy Markdown
Owner

Hmbown commented May 31, 2026

Thanks for the protocol docs. I pushed a maintainer follow-up that runs rustfmt and merges current main into the branch so the already-landed secrets docs are no longer replayed as stale stacked context. Local checks passed in the PR worktree: cargo fmt --all --check, cargo test -p codewhale-protocol --all-features --locked, and git diff --check.

@Hmbown Hmbown merged commit 0302ace into Hmbown:main May 31, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants