Skip to content

Fix TUI cancel busy animations#2465

Merged
Hmbown merged 1 commit into
mainfrom
codex/esc-cancel-retry-ui
May 31, 2026
Merged

Fix TUI cancel busy animations#2465
Hmbown merged 1 commit into
mainfrom
codex/esc-cancel-retry-ui

Conversation

@Hmbown
Copy link
Copy Markdown
Owner

@Hmbown Hmbown commented May 31, 2026

Summary

  • clear local busy turn state, retry banner, and runtime turn id when Esc/Ctrl+C cancels a turn
  • stop terminal title/taskbar busy animations for cancelled, failed, and completed turns
  • keep Esc routed to cancel when runtime status is still in_progress after a loading-state race

Tests

  • cargo test -p codewhale-tui local_cancel_marks_late_stream_events_for_suppression -- --nocapture
  • cargo test -p codewhale-tui next_escape_action_cancels_in_progress_runtime_even_if_loading_flag_was_cleared -- --nocapture
  • cargo test -p codewhale-tui retry_status -- --nocapture
  • cargo test -p codewhale-tui turn_liveness -- --nocapture
  • cargo test -p codewhale-tui

Copilot AI review requested due to automatic review settings May 31, 2026 21:03
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@Hmbown Hmbown merged commit f09b4ae into main May 31, 2026
14 of 15 checks passed
@Hmbown Hmbown deleted the codex/esc-cancel-retry-ui branch May 31, 2026 21:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants