Skip to content

[codex] hide plugin command from root slash menu#3959

Merged
Hmbown merged 1 commit into
Hmbown:mainfrom
nightt5879:nightt5879/issue-3910-plugin-discovery-tier
Jul 3, 2026
Merged

[codex] hide plugin command from root slash menu#3959
Hmbown merged 1 commit into
Hmbown:mainfrom
nightt5879:nightt5879/issue-3910-plugin-discovery-tier

Conversation

@nightt5879

Copy link
Copy Markdown
Contributor

Summary

  • Fix /plugin discovery tiering by using the canonical command name in the Advanced list.
  • Expose discovery tier name lists to registry tests so aliases cannot drift into the hardcoded tier list again.
  • Cover the slash menu acceptance: /plugin is hidden from bare / discovery but appears when typing /pl.

Fixes #3910

Validation

  • cargo fmt
  • git diff --check
  • python scripts/check-coauthor-trailers.py --author-map .github/AUTHOR_MAP --range upstream/main..HEAD --check-authors
  • cargo test -p codewhale-tui --bin codewhale-tui --locked command_discovery_tier_lists_use_canonical_registered_names -- --nocapture
  • cargo test -p codewhale-tui --bin codewhale-tui --locked slash_completion_hints_hide_toolbox_commands_until_typed -- --nocapture
  • cargo test -p codewhale-tui --bin codewhale-tui --locked slash_completion_hints -- --nocapture
  • cargo test -p codewhale-tui --bin codewhale-tui --locked command_registry -- --nocapture
  • cargo test -p codewhale-tui --bin codewhale-tui --locked command_info -- --nocapture
  • cargo test -p codewhale-tui --bin codewhale-tui --locked
  • cargo test --workspace --locked

Self-review

  • Scope is limited to command discovery metadata and existing slash completion tests.
  • No command dispatch, plugin registry, or alias behavior changes beyond hiding the canonical /plugin entry from root discovery.
  • The new registry test fails if a future Advanced/Compatibility tier entry names an alias or a nonexistent command.

Use the canonical plugin command name in the advanced discovery tier so /plugin stays out of the bare slash menu while still matching typed prefixes. Expose the tier lists to tests and cover both canonical registry drift and /plugin completion behavior.

Fixes Hmbown#3910

Validation:
- cargo fmt
- git diff --check
- cargo test -p codewhale-tui --bin codewhale-tui --locked command_discovery_tier_lists_use_canonical_registered_names -- --nocapture
- cargo test -p codewhale-tui --bin codewhale-tui --locked slash_completion_hints_hide_toolbox_commands_until_typed -- --nocapture
- cargo test -p codewhale-tui --bin codewhale-tui --locked slash_completion_hints -- --nocapture
- cargo test -p codewhale-tui --bin codewhale-tui --locked command_registry -- --nocapture
- cargo test -p codewhale-tui --bin codewhale-tui --locked command_info -- --nocapture
- cargo test -p codewhale-tui --bin codewhale-tui --locked
- cargo test --workspace --locked

Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
@nightt5879 nightt5879 requested a review from Hmbown as a code owner July 3, 2026 01:57
@Hmbown Hmbown merged commit d57254c into Hmbown:main Jul 3, 2026
14 checks passed
Hmbown added a commit that referenced this pull request Jul 3, 2026
Preserve the scanner-backed /plugin behavior from #3970 while keeping the canonical command name introduced by #3959. The plural /plugins spelling remains an alias, so typed compatibility still works without exposing the alias in discovery tiers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(tui/slash-menu): /plugin escapes the Advanced tier — discovery list says "plugins" but the command is named "plugin"

2 participants