test: Add lock to fix env conflict in test#4031
Merged
Merged
Conversation
Hmbown
approved these changes
Jul 5, 2026
Hmbown
left a comment
Owner
There was a problem hiding this comment.
Correct fix: direct_provider_ignores_foreign_deepseek_root_default_model reads DEEPSEEK_BASE_URL while a sibling test writes it; taking lock_test_env() serializes them. Matches the established pattern in this file. CI green across all three OSes. Thanks @hongqitai.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test
direct_provider_ignores_foreign_deepseek_root_default_modelwill read envDEEPSEEK_BASE_URL.But
deepseek_base_url_env_scopes_to_self_hosted_providerswill write it and cause test failed.Use
lock_test_envget lock before test indirect_provider_ignores_foreign_deepseek_root_default_model.Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo test --workspace --all-featuresChecklist