최단경로#131
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements Dijkstra's algorithm to solve the shortest path problem, including a custom min-heap implementation. The review feedback suggests several performance optimizations for competitive programming, such as using faster I/O methods instead of readLine() and batching output into a single string to avoid multiple print calls. Additionally, minor refactoring of the Heap struct is recommended to simplify the initializer by declaring the elements array with an initial value.
| var graph = [[(w: Int, v: Int)]](repeating: [], count: v + 1) | ||
|
|
||
| for _ in 0..<e { | ||
| let input = readLine()!.split(separator: " ").compactMap { Int($0) } |
Contributor
Comment on lines
+28
to
+31
| for i in 1...v { | ||
| let dist = dists[i] | ||
| print(dist == Int.max ? "INF" : dist) | ||
| } |
Contributor
There was a problem hiding this comment.
| } | ||
|
|
||
| struct Heap<T> { | ||
| var elements: [T] |
Contributor
Comment on lines
+40
to
+43
| init(_ priority: @escaping (T, T) -> Bool) { | ||
| self.elements = [] | ||
| self.priority = priority | ||
| } |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 문제 링크
✔️ 소요된 시간
50m + 20m
⏰ 시간 복잡도
O(ElogE)