Conversation
… jquery_rails dependency
Member
|
If this is sufficient, then go for it. |
iox
added a commit
that referenced
this pull request
Jun 23, 2013
Closes #34. Use bundle update in wizard in order to correctly resolve jquery_rails dependency
Member
Author
|
Ok, I just merged it. I don't have permissions to push the gems, can you do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tried upgrading to jquery_rails 3.0, but they have stopped including jquery_ui. Instead they recomment using jquery-ui-rails, and in turn we'd have to modify application.js and test that the jquery ui templates work correctly. It can be done, but I guess this change would make sense in the Rails 4 branch.
As a workaround, I suggest we exchange this "bundle install" for "bundle update", and push "Hobo 2.0.1". This way new users will be able to install Hobo without an ugly error :).
What do you think? @bryanlarsen , @barquin