Initial implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
reviewed
Jul 3, 2019
| import Data.List (lookup) | ||
| import Data.List.NonEmpty (NonEmpty (..)) | ||
| import Data.Text (Text) | ||
| import Data.Text.Encoding (decodeUtf8) |
There was a problem hiding this comment.
Heh, I think it was painful to write all these imports without relude...
| :: forall m . WithError m | ||
| => NonEmpty Name -- ^ List of the names used in query | ||
| -> [NamedParam] -- ^ List of the named parameters | ||
| -> m (NonEmpty PG.Action) |
There was a problem hiding this comment.
It's nice that this function is abstracted over WithError monad. This means that in this package we can also implement queryNamed and executeNamed functions 👍 No necessary in this PR, but should be possible in theory.
| > queryNamed [sql| | ||
| > SELECT * | ||
| > FROM table | ||
| > WHERE foo = ?foo |
There was a problem hiding this comment.
Wow, it's very nice to such docs in the .cabal file description! Good idea!
Co-Authored-By: Dmitrii Kovanikov <dmitrii@holmusk.com>
chshersh
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.