Update to the new Images#29
Merged
Merged
Conversation
I'm a little concerned that something might have changed to worsen performance, but it's not obvious what that would be. This might merit some more investigation, but since visual inspection suggests it usually does pretty well this seems like a reasonable change.
Member
Author
|
Test failure is yet again the difference between the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had overlooked this repository when updating to the new Images. The only concern is that there were some occasional failures in the "apertured" test; I can't remember, however, whether it always passed previously and I didn't downgrade my packages to test. When I inspected the images it seems things are OK but not perfect (but I don't think they ever were perfect). So I allowed a couple of failures before getting really concerned.