Cjg/inputs wip #22
Merged
Cjg/inputs wip #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essential input commands and to support reading of .ai and .i files
…rt writing of inputs to the command file (and adding essential inputs automatically when omitted). Also required a small fix to support reading of the files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us most of the way to the goal of supporting analog and digital input channels. The remaining task is to integrate loading of .ai and .di files into a set of
ImagineCommandobjects. When we support that maybe we should consider changing the name ofImagineCommandtoImagineSignalto clarify that it can hold input or output samples. That's for another PR.