Skip to content

Conversation

@Cody-G
Copy link
Contributor

@Cody-G Cody-G commented Sep 20, 2017

This modifies the command file format as discussed in #40. Old scripts used to generate command files should still work with this new version. However if you have any old command files that you want to read with ImagineInterface, then they may not read correctly after we merge this.

In case users do need to read old command files they can checkout the newly-tagged "v0.1" release. I'll wait a day or two for user comments before I merge this.

@codecov-io
Copy link

codecov-io commented Sep 21, 2017

Codecov Report

Merging #42 into master will decrease coverage by 0.09%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #42     +/-   ##
=========================================
- Coverage   83.26%   83.16%   -0.1%     
=========================================
  Files          12       12             
  Lines         962      992     +30     
=========================================
+ Hits          801      825     +24     
- Misses        161      167      +6
Impacted Files Coverage Δ
src/parse.jl 85.54% <100%> (-0.09%) ⬇️
src/validate_single.jl 98.9% <100%> (ø) ⬆️
src/write.jl 91.2% <87.5%> (-2.24%) ⬇️
src/sequence_analysis.jl 81.25% <0%> (-12.5%) ⬇️
src/metadata_constants.jl 83.33% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b349a...c12162c. Read the comment docs.

@Cody-G
Copy link
Contributor Author

Cody-G commented Sep 21, 2017

I added a couple of fixes, will merge this tomorrow if I don't get any complaints.

@Cody-G Cody-G merged commit c1b19cc into master Sep 22, 2017
@Cody-G Cody-G deleted the cjg/new_json branch September 22, 2017 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants