Support reduced frame size in validation #78
Conversation
If you're acquiring less than the full chip, the frame rate might exceed what's possible when using the full chip. Allow users to pass the number of vertical lines acquired as part of write_commands.
|
Opps! I already did this and about to do pull request. But your commit looks better. |
|
So sorry! I should have coordinated with you. |
|
Anything that you like better about yours, feel free to add to this branch. |
|
Other than this topic, If user can use ImaginePlots.jl with ImagineInterface it would be better to work. But ImaginPlots uses UnitfulPlots.jl which is still living in julia0.7 so I forked it to my repo. and added Project.toml then it still works. Is it ok to fork the UnitfulPlots.jl to our Holylab repo. and do the pull request of the modificaitons in ImaginePlots.jl? |
|
Sure. But have you submitted a PR to update the official UnitfulPlots.jl? I don't see any open pull requests. |
|
I didn't do yet. |
|
Go for it! The world is your oyster, don't be shy. You're good at this stuff! 😃 |
2 participants
This fixes a bug reported via email by @jona125. The key change is allowing the user to pass
vertical_linestowrite_commandsto communicate the anticipated frame size. I am not sure whether there's any way of using the same value to control the acquisition.I'm happy to accept feedback on any of this, including the naming of the parameter
vertical_lines.