Skip to content

Fix end_timestamp format - url quoting needed #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrandMoff100 merged 1 commit into from
Jun 15, 2022
Merged

Fix end_timestamp format - url quoting needed #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions homeassistant_api/rawapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from datetime import datetime
from posixpath import join
from typing import Dict, Optional, Tuple, Union
from urllib.parse import quote as url_quote

from .const import DATE_FMT
from .models import Entity
Expand Down Expand Up @@ -114,7 +115,7 @@ def prepare_get_entity_histories_params(
if entities is not None:
params["filter_entity_id"] = ",".join([ent.entity_id for ent in entities])
if end_timestamp is not None:
params["end_time"] = end_timestamp.strftime(DATE_FMT)
params["end_time"] = url_quote(end_timestamp.strftime(DATE_FMT))
if minimal_state_data:
params["minimal_response"] = None
if significant_changes_only:
Expand Down Expand Up @@ -143,7 +144,7 @@ def prepare_get_logbook_entry_params(
params.update(entity=filter_entity.entity_id)
if end_timestamp is not None:
if isinstance(end_timestamp, datetime):
end_timestamp = end_timestamp.strftime(DATE_FMT)
end_timestamp = url_quote(end_timestamp.strftime(DATE_FMT))
params.update(end_time=end_timestamp)
if start_timestamp is not None:
if isinstance(start_timestamp, datetime):
Expand Down