Easier way to omit ssl verification#145
Conversation
|
This is a cool idea! I'm interested in hearing more about the motivation for your idea and what your use case is like. Could you tell us more about that? |
I wrote a Python module (fritz-advanced-thermostat) to control the offset of FRITZ!DECT30X Thermostats. The manufacture AVM is unfortunately unwilling to let us control the offset via the official API, so I'm using selenium + chromium to do so. So now I'm using HomeAssistantAPI in combination with fritz-advanced-thermostat in a docker container on my NAS and since I'm running all my internal services on https I needed a way to disable ssl verification. I thought adding the option in general would spare some one with a similar use case the hassle of digging through the source code. |
|
Sounds awesome. |
GrandMoff100
left a comment
There was a problem hiding this comment.
Testing Fixes
The verify parameter isn't accepted by the aiohttp.request method, which is why some of the tests are failing, as this default parameter value is being added to all async test requests. I'd propose we move the parameter to RawClient, the synchronous client that uses requests.
Styling Fixes
This part definitely isn't your fault but we just need to fix the type annotation for global_request_kwargs to dict[str, Any] | None in a few spots.
|
@mietzen could you add me as a collaborator with push permissions on your form so I may polish this PR to pass quality checks? |
|
No worries 👍 I got you. |
|
Manually merging this because the tests pass on my machine. GitHub isn't passing the |
Easier way to omit ssl verification

You can now use:
instead of: