Skip to content

Merge Pydantic Models#58

Merged
GrandMoff100 merged 4 commits into
masterfrom
feature/pydantic_models
Feb 18, 2022
Merged

Merge Pydantic Models#58
GrandMoff100 merged 4 commits into
masterfrom
feature/pydantic_models

Conversation

@GrandMoff100
Copy link
Copy Markdown
Collaborator

Pydantic models replace JsonModels and allow us to also do data validation and to have more extensive and rigorous type hinting in JSON responses compared to the previous JSON model that was implemented from scratch (not very well admitedly).

@GrandMoff100 GrandMoff100 added the enhancement New feature or request label Feb 18, 2022
@GrandMoff100
Copy link
Copy Markdown
Collaborator Author

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 3 0 0.06s
✅ CREDENTIALS secretlint yes no 0.93s
✅ CSS stylelint 1 0 0 1.25s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 2 0 0 1.06s
✅ JSON jsonlint 2 0 0.59s
✅ JSON prettier 2 0 0 1.2s
✅ JSON v8r 2 0 1.96s
✅ MARKDOWN markdownlint 6 0 0 0.37s
✅ MARKDOWN markdown-link-check 6 0 1.48s
✅ MARKDOWN markdown-table-formatter 6 0 0 0.29s
⚠️ SPELL cspell 25 1 0.65s
✅ SPELL misspell 25 0 0 0.06s
✅ YAML prettier 6 0 0 1.35s
✅ YAML v8r 6 0 6.04s
✅ YAML yamllint 6 0 0.18s

See errors details in artifact MegaLinter reports on CI Job page

@GrandMoff100 GrandMoff100 merged commit 523b37c into master Feb 18, 2022
@GrandMoff100 GrandMoff100 linked an issue Feb 18, 2022 that may be closed by this pull request
adamlogan73 pushed a commit that referenced this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Switch from JsonModel to pydantic models

1 participant