Skip to content

git-try-push: add origin_branch option#151

Merged
nandahkrishna merged 1 commit intoHomebrew:masterfrom
nandahkrishna:git-try-push-force
Mar 17, 2021
Merged

git-try-push: add origin_branch option#151
nandahkrishna merged 1 commit intoHomebrew:masterfrom
nandahkrishna:git-try-push-force

Conversation

@nandahkrishna
Copy link
Copy Markdown
Member

See Homebrew/brew#10856 and this comment for context. This PR adds the ability to git push --force-with-lease on the first try, using a separate flag.

@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Mar 15, 2021

Just to cross-ref my comments on the force functionality: Homebrew/brew#10856 (comment)

@nandahkrishna nandahkrishna changed the title git-try-push: force-with-lease push on first try git-try-push: add force-overwrite option Mar 16, 2021
@nandahkrishna
Copy link
Copy Markdown
Member Author

Changes have been addressed, just wondering if the origin_branch suggested was supposed to be an additional input.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Changes have been addressed, just wondering if the origin_branch suggested was supposed to be an additional input.

@nandahkrishna Yeh, sorry: I'd suggest that force-master be dropped as an option and replaced with origin_branch

@nandahkrishna nandahkrishna changed the title git-try-push: add force-overwrite option git-try-push: add origin_branch option Mar 17, 2021
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@nandahkrishna
Copy link
Copy Markdown
Member Author

Thanks! Merging this.

@nandahkrishna nandahkrishna merged commit 7bff57f into Homebrew:master Mar 17, 2021
@nandahkrishna nandahkrishna deleted the git-try-push-force branch March 17, 2021 10:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants