Linkage can fail spuriously for newly installed formulae

[mikhailkoliada]

brew gist-logs <formula> link OR brew config AND brew doctor output

: 3.6.0-24-g5524b30
ORIGIN: https://github.com/Homebrew/brew
HEAD: 5524b302d83a54660c49e850b3bc1558371c2fbc
Last commit: 27 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 6f7e54470b33fe838ac4fbccd47d743a8baee15d
Core tap last commit: 24 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS: 3650
HOMEBREW_MAKE_JOBS: 1
HOMEBREW_NO_AUTO_UPDATE: set
Homebrew Ruby: 2.6.8 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/bin/ruby
CPU: single-core 64-bit haswell
Clang: N/A
Git: 2.25.1 => /bin/git
Curl: 7.68.0 => /bin/curl
Kernel: Linux 5.15.0-1019-azure x86_64 GNU/Linux
OS: Ubuntu 20.04.5 LTS (focal)
Host glibc: 2.31
/usr/bin/gcc: 9.4.0
/usr/bin/ruby: N/A
glibc: 2.35
gcc@11: 11.3.0
xorg: N/A

```brew doctor
Your system is ready to brew```

Verification

• I ran brew update and am still able to reproduce my issue.
• I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?

actions/runner-images projects installs zstd from brew on Ubuntu 18.04 and 20.04 (just to make sure it is always present in the system as customers demand it a lot). With homebrew 3.6.0 gcc@11 has become a mandatory dependency for any package, so we decided to add gcc@11 into our list (put it first), and expected zstd's explicit installation to be quietly ignored as it is pulled by gcc itself in anyway (but we still want to keep it listed explicitly, just in case).

What happened (include all command output)?

After test CI runs we have noticed that brew experienced linkge problems for gcc an it tries to rebuild itself from sources, while it should not. See build runs

What did you expect to happen?

zstd installation ignored and no linkage problems for gcc@11

Step-by-step reproduction instructions (by running brew commands)

`brew install gcc@11`
`brew install zstd`

[mikhailkoliada]

gcc linkage:

Warning: linkage is a developer command, so
Homebrew's developer mode has been automatically turned on.
To turn developer mode off, run brew developer off

Homebrew libraries:
  /home/linuxbrew/.linuxbrew/Cellar/glibc/2.35/lib64/ld-linux-x86-64.so.2 (glibc)
  /home/linuxbrew/.linuxbrew/lib/libc.so.6 (glibc)
  /home/linuxbrew/.linuxbrew/lib/libdl.so.2 (glibc)
  /home/linuxbrew/.linuxbrew/lib/libm.so.6 (glibc)
  /home/linuxbrew/.linuxbrew/lib/libpthread.so.0 (glibc)
  /home/linuxbrew/.linuxbrew/lib/librt.so.1 (glibc)
  /home/linuxbrew/.linuxbrew/opt/gmp/lib/libgmp.so.10 (gmp)
  /home/linuxbrew/.linuxbrew/opt/isl/lib/libisl.so.23 (isl)
  /home/linuxbrew/.linuxbrew/opt/libmpc/lib/libmpc.so.3 (libmpc)
  /home/linuxbrew/.linuxbrew/opt/mpfr/lib/libmpfr.so.6 (mpfr)
  /home/linuxbrew/.linuxbrew/opt/zlib/lib/libz.so.1 (zlib)
  /home/linuxbrew/.linuxbrew/opt/zstd/lib/libzstd.so.1 (zstd)
Missing libraries:
  libgcc_s.so.1
Broken dependencies:
  /home/linuxbrew/.linuxbrew/opt/gcc@11/lib/gcc/11/libgcc_s.so.1 (gcc@11)
  /home/linuxbrew/.linuxbrew/opt/gcc@11/lib/gcc/11/libquadmath.so.0 (gcc@11)
  /home/linuxbrew/.linuxbrew/opt/gcc@11/lib/gcc/11/libstdc++.so.6 (gcc@11)

zstd linkage:

brew linkage zstd
Homebrew libraries:
  /home/linuxbrew/.linuxbrew/lib/libc.so.6 (glibc)
  /home/linuxbrew/.linuxbrew/lib/libpthread.so.0 (glibc)
  /home/linuxbrew/.linuxbrew/opt/lz4/lib/liblz4.so.1 (lz4)
  /home/linuxbrew/.linuxbrew/opt/xz/lib/liblzma.so.5 (xz)
  /home/linuxbrew/.linuxbrew/opt/zlib/lib/libz.so.1 (zlib)
  /home/linuxbrew/.linuxbrew/Cellar/zstd/1.5.2/bin/../lib/libzstd.so.1 (zstd)
Missing libraries:
  libgcc_s.so.1
  libstdc++.so.6

[carlocab]

I've seen this bug a few times too. It would be good to fix it.

As a workaround, try installing it in multiple steps:

brew install glibc
brew install --only-dependencies gcc@11
brew install gcc@11

[carlocab]

I can reproduce it consistently with this workflow.

After a fresh brew install gcc@11, we get the following failure for brew linkage --test gcc@11:

Missing libraries:
  unexpected (libgcc_s.so.1)
  unexpected (libquadmath.so.0)
  unexpected (libstdc++.so.6)
  unexpected (libzstd.so.1)

This seems to be because after reinstalling, we see:

==> Reinstalling 3 dependents with broken linkage from source:
binutils, zstd, gcc@11

In my case, brew doesn't actually go through reinstalling any of the above formulae from source.

If we run ls -la "$(brew --cellar gcc@11)", we see why linkage is broken:

total 12
drwxr-xr-x   3 runner docker 4096 Sep  9 17:37 .
drwxr-xr-x+ 13 runner docker 4096 Sep  9 17:37 ..
drwxr-xr-x   8 runner docker 4096 Sep  9 17:37 11.3.0.reinstall

I get the same results when running the same tests inside a Docker container. (workflow)

There appear to be two bugs here:

1. The linkage test should not fail on a fresh install, to avoid triggering a source rebuild.
2. The source rebuild should probably either not abort after moving the prefix to "#{prefix}.reinstall", or put it back after aborting.

[Bo98]

Thanks, I can reproduce the issue and am looking into it.

2. The source rebuild should probably either not abort after moving the prefix to "#{prefix}.reinstall", or put it back after aborting.

This should be a separate bug report. I'm looking into libstdc++ & libgcc_s linkage issue specifically.