test: don't try to use Xcode SDK for build requirement#10048
Merged
Rylan12 merged 1 commit intoHomebrew:masterfrom Dec 21, 2020
Rylan12:fix-test-sdk-detection
Merged
test: don't try to use Xcode SDK for build requirement#10048Rylan12 merged 1 commit intoHomebrew:masterfrom Rylan12:fix-test-sdk-detection
Rylan12 merged 1 commit intoHomebrew:masterfrom
Rylan12:fix-test-sdk-detection
Conversation
Contributor
|
Review period ended. |
BrewTestBot
approved these changes
Dec 18, 2020
5 tasks
Member
|
Tested this locally with the existing Works perfectly fine. |
MikeMcQuaid
reviewed
Dec 18, 2020
Member
Author
|
Updated to simplify/clarify the logic and switch to using keyword arguments instead of |
MikeMcQuaid
approved these changes
Dec 21, 2020
Member
|
Thanks @Rylan12! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?Previously, running
brew testfailed if the formula had an Xcode build requirement but the user did not have Xcode installed.brewwould see the Xcode requirement and default to the Xcode SDK. However, for formula that only need Xcode to build, this check is unnecessary when simply testing the formula. I ran into this in Homebrew/homebrew-core#67043 withdeno:I don't have code installed, so
Xcode.sdk.pathfailed (Xcode.sdkisnil).My solution is to, when testing, pass a flag to the
macosxsdkmethod to determine whether to check only runtime requirements. When this is false (the default), any Xcode requirement will require the use of the Xcode SDK. When set to true (only inbrew test), build-only Xcode requirements will not necessarily require the Xcode SDK.I'm marking this PR as
criticalbecause I believe it fixes a bug. However, I'm not familiar at all with the files that I'm changing so it's entirely possible that this change will have unintended consequences. I will not merge until I have approvals from other maintainers who are more familiar with this code.