Skip to content

shared_audits: add xit to GITHUB_PRERELEASE_ALLOWLIST#10053

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
miccal:shared-audits-update
Dec 20, 2020
Merged

shared_audits: add xit to GITHUB_PRERELEASE_ALLOWLIST#10053
reitermarkus merged 1 commit intoHomebrew:masterfrom
miccal:shared-audits-update

Conversation

@miccal
Copy link
Copy Markdown
Contributor

@miccal miccal commented Dec 18, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Required for Homebrew/homebrew-cask#95593 to pass audit.

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2020-12-21 at 08:00:52 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 18, 2020
@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Dec 18, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Dec 18, 2020

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 18, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

@Rylan12 Is this one you expect to be ported over at some stage?

@Rylan12
Copy link
Copy Markdown
Member

Rylan12 commented Dec 18, 2020

Yes, thanks for reminding me. Just re-added this to my to-do list. Depending on when I have availability it might be this weekend. I'd say merge this because so it's not blocking anything. No need to wait for the migration.

@reitermarkus
Copy link
Copy Markdown
Member

@miccal, can you rebase this?

@reitermarkus reitermarkus merged commit f47c1ea into Homebrew:master Dec 20, 2020
@miccal miccal deleted the shared-audits-update branch December 20, 2020 08:19
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 20, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants