Skip to content

formula: activate env extensions for postinstall#10062

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:postinstall-env
Dec 22, 2020
Merged

formula: activate env extensions for postinstall#10062
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:postinstall-env

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This allows ENV.prepend_path calls during postinstall

Another way to do this would be:

ENV.extend SharedEnvExtension

Related: Homebrew/homebrew-core#66722, Homebrew/homebrew-core#66910

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2020-12-21 at 20:41:57 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 18, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 21, 2020
@MikeMcQuaid MikeMcQuaid merged commit 2c4aea9 into Homebrew:master Dec 22, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @SeekingMeaning!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 22, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants