utils: add AST helper functions for editing formulae#10064
Merged
SeekingMeaning merged 2 commits intoHomebrew:masterfrom Dec 23, 2020
Merged
utils: add AST helper functions for editing formulae#10064SeekingMeaning merged 2 commits intoHomebrew:masterfrom
SeekingMeaning merged 2 commits intoHomebrew:masterfrom
Conversation
Contributor
|
Review period will end on 2020-12-22 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
SeekingMeaning
force-pushed
the
ast
branch
3 times, most recently
from
bab78f6 to
132778e
Compare
MikeMcQuaid
approved these changes
Dec 21, 2020
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Very nice so far 👏🏻 . Some basic unit tests for these would be nice (when you've nailed down the functionality).
dawidd6
reviewed
Dec 21, 2020
BrewTestBot
removed
the
waiting for feedback
Contributor
|
Review period ended. |
BrewTestBot
approved these changes
Dec 22, 2020
MikeMcQuaid
approved these changes
Dec 23, 2020
Member
|
Great work here @SeekingMeaning! |
Contributor
|
I agree, this is very cool. Nice job! |
dawidd6
approved these changes
Dec 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?This PR adds two functions:
Utils::AST.replace_formula_stanza!Utils::AST.add_formula_stanza!These will be useful for gradually replacing regexes (which can sometimes be unreliable)