Skip to content

cli: fix underlined multi-line help text#10065

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:cli-help-underline
Dec 21, 2020
Merged

cli: fix underlined multi-line help text#10065
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:cli-help-underline

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

@SeekingMeaning SeekingMeaning commented Dec 19, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Help text such as *May remove files which are shared between applications.* is automatically underlined by CLI::Parser

This pull request fixes underlines for wrapped text made to fit the terminal window.
This can be tested with brew help remove, particularly these two lines:

                                   May remove files which are shared between
                                   applications.

Without this PR, the spaces preceding the word applications are underlined.

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2020-12-22 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 19, 2020
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 21, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 21, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Dec 21, 2020

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit 54c9309 into Homebrew:master Dec 21, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 21, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants