Merged
Conversation
MikeMcQuaid
reviewed
Dec 23, 2020
Library/Homebrew/cmd/search.rb
Outdated
|
|
||
| switch "--open", | ||
| depends_on: "--pull-request", | ||
| description: "Search for GitHub open pull requests" |
Member
There was a problem hiding this comment.
Suggested change
| description: "Search for GitHub open pull requests" | |
| description: "Search for only open GitHub pull requests" |
Library/Homebrew/cmd/search.rb
Outdated
| description: "Search for GitHub open pull requests" | ||
| switch "--closed", | ||
| depends_on: "--pull-request", | ||
| description: "Search for GitHub closed pull requests" |
Member
There was a problem hiding this comment.
Suggested change
| description: "Search for GitHub closed pull requests" | |
| description: "Search for only closed GitHub pull requests" |
Library/Homebrew/cmd/search.rb
Outdated
Comment on lines
+100
to
+101
| only = "open" if args.open? && !args.closed? | ||
| only = "closed" if args.closed? && !args.open? |
Member
There was a problem hiding this comment.
Might be nice to make this a single if
| def print_pull_requests_matching(query) | ||
| open_or_closed_prs = search_issues(query, type: "pr", user: "Homebrew") | ||
| def print_pull_requests_matching(query, only) | ||
| open_or_closed_prs = search_issues(query, is: only, type: "pr", user: "Homebrew") |
Member
There was a problem hiding this comment.
Is this handled as expected when only is nil?
Contributor
Author
There was a problem hiding this comment.
Yes, the result when only is nil is below.
brew search ruby --pul-request
==> Open pull requests
licensee 9.14.1 (new formula) (https://github.com/Homebrew/homebrew-core/pull/67513)
colorls 1.4.3 (new formula) (https://github.com/Homebrew/homebrew-core/pull/67165)
tpp: fix build with Xcode 12 (https://github.com/Homebrew/homebrew-core/pull/66517)
vowpal-wabbit 8.9.0 (https://github.com/Homebrew/homebrew-core/pull/64736)
dashing: update (https://github.com/Homebrew/homebrew-core/pull/65648)
install.sh: preload homebrew/core before brew update (https://github.com/Homebrew/install/pull/371)
tomee-plume 8.0.5 (https://github.com/Homebrew/homebrew-core/pull/65750)
Adds support for ManyCam (https://github.com/Homebrew/homebrew-cask/pull/91231)
minidlna 1.3.0 (https://github.com/Homebrew/homebrew-core/pull/65760)
Fix/m4/patch (https://github.com/Homebrew/linuxbrew-core/pull/21848)
mermaid-cli 8.8.4 (new formula) (https://github.com/Homebrew/homebrew-core/pull/65521)
openjdk: Add support for Apple silicon (https://github.com/Homebrew/homebrew-core/pull/65670)
alluxio 2.4.1 (https://github.com/Homebrew/homebrew-core/pull/65422)
autoconf 2.70 (https://github.com/Homebrew/homebrew-core/pull/66511)
geant4 10.7.0 (https://github.com/Homebrew/homebrew-core/pull/66422)
workflows: add remove-disabled-formulae workflow (https://github.com/Homebrew/homebrew-core/pull/67386)
Check flavour to prevent mixed architectures (https://github.com/Homebrew/brew/pull/9126)
go update gobootstrap on arm mac to a native arm version (https://github.com/Homebrew/homebrew-core/pull/67154)
onedrive-linux-client 2.4.5 (new formula) (https://github.com/Homebrew/homebrew-core/pull/64256)
ldc: use llvm (https://github.com/Homebrew/homebrew-core/pull/61117)
build(deps): bump rubocop from 1.5.1 to 1.6.1 in /Library/Homebrew (https://github.com/Homebrew/brew/pull/10050)
==> Closed pull requests
ruby-build 20201221 (https://github.com/Homebrew/homebrew-core/pull/67338)
utils/ruby: silence `which` errors when finding ruby (https://github.com/Homebrew/brew/pull/10034)
ruby-install 0.8.1 (https://github.com/Homebrew/homebrew-core/pull/67413)
utils/ruby.sh: simplify and fix Ruby-related logic (https://github.com/Homebrew/brew/pull/9472)
utils/ruby.sh: various tweaks (https://github.com/Homebrew/brew/pull/9544)
ruby-build 20201210 (https://github.com/Homebrew/homebrew-core/pull/66624)
ruby@2.4: deprecate! (https://github.com/Homebrew/homebrew-core/pull/66473)
ruby-build 20201208 (https://github.com/Homebrew/homebrew-core/pull/66470)
ruby-install 0.8.0 (https://github.com/Homebrew/homebrew-core/pull/66784)
cleanup: fix portable Ruby behaviour. (https://github.com/Homebrew/brew/pull/9479)
Fix macOS Ruby version handling (https://github.com/Homebrew/brew/pull/9465)
libprelude: explicitly disable Python 2 bindings and depend on ruby@2.6 for ruby bindings (https://github.com/Homebrew/linuxbrew-core/pull/21756)
ruby-build 20201118 (https://github.com/Homebrew/homebrew-core/pull/65111)
ruby-build 20201117 (https://github.com/Homebrew/homebrew-core/pull/65026)
Dependabot/bundler/library/homebrew/ruby macho 2.5.0 (https://github.com/Homebrew/brew/pull/10104)
tests.yml: force vendored Ruby on Catalina (https://github.com/Homebrew/homebrew-core/pull/66290)
Merge 2020-12-09 4f5a1e9aa59 (https://github.com/Homebrew/linuxbrew-core/pull/21752)
brew.sh: don't allow system Ruby on Catalina. (https://github.com/Homebrew/brew/pull/9442)
Improved no_usable_ruby() test (https://github.com/Homebrew/install/pull/338)
fq 0.13.4 (https://github.com/Homebrew/homebrew-core/pull/66917)
...
Library/Homebrew/utils/github.rb
Outdated
|
|
||
| def print_pull_requests_matching(query) | ||
| open_or_closed_prs = search_issues(query, type: "pr", user: "Homebrew") | ||
| def print_pull_requests_matching(query, only) |
Member
There was a problem hiding this comment.
Suggested change
| def print_pull_requests_matching(query, only) | |
| def print_pull_requests_matching(query, only: nil) |
Contributor
Author
There was a problem hiding this comment.
def print_pull_requests_matching(query, only: nil) caused error like below.
$brew search ruby --pul-request
Error: wrong number of arguments (given 2, expected 1)
Please report this issue:
https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/utils/github.rb:345:in `print_pull_requests_matching'
/usr/local/Homebrew/Library/Homebrew/cmd/search.rb:106:in `search'
/usr/local/Homebrew/Library/Homebrew/brew.rb:124:in `<main>'
I will write def print_pull_requests_matching(query, only = nil)
Member
There was a problem hiding this comment.
def print_pull_requests_matching(query, only: nil)caused error like below.
Yes, all the callers will need updated too. I think my version is a bit more readable.
hyuraku
force-pushed
the
add-options-to-search
branch
from
e7abc4d to
0b574ef
Compare
MikeMcQuaid
approved these changes
Dec 28, 2020
Member
|
@hyuraku Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?add two options to
cmd/searchfor whether pull requests you search are open or closed`.