Skip to content

bottle --merge: add more write tests#10097

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
iMichka:bottle-write-test2
Dec 23, 2020
Merged

bottle --merge: add more write tests#10097
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
iMichka:bottle-write-test2

Conversation

@iMichka
Copy link
Copy Markdown
Member

@iMichka iMichka commented Dec 22, 2020

In preparation for #9315

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Dec 22, 2020

Review period will end on 2020-12-23 at 15:56:39 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 22, 2020
@iMichka
Copy link
Copy Markdown
Member Author

iMichka commented Dec 22, 2020

Funny that the code coverage did not increase. It looks like the modified files were ignored by codecov.

SeekingMeaning
SeekingMeaning reviewed Dec 22, 2020
View reviewed changes
Comment thread Library/Homebrew/test/dev-cmd/bottle_spec.rb Outdated
Comment thread Library/Homebrew/test/dev-cmd/bottle_spec.rb Outdated
Comment thread Library/Homebrew/test/dev-cmd/bottle_spec.rb Outdated
Comment thread Library/Homebrew/test/dev-cmd/bottle_spec.rb Outdated
@iMichka iMichka enabled auto-merge December 22, 2020 20:09
@SeekingMeaning SeekingMeaning mentioned this pull request Dec 22, 2020
Merged
8 tasks
@SeekingMeaning
Copy link
Copy Markdown
Contributor

SeekingMeaning commented Dec 23, 2020 •
edited
Loading

There appears to be a duplicate test everything (macOS) workflow that failed for some reason

@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Dec 23, 2020

There appears to be a duplicate test everything (macOS) workflow that failed for some reason

Weird. Will go away with a rebase I'm sure.

@iMichka
Copy link
Copy Markdown
Member Author

iMichka commented Dec 23, 2020

Rebased.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 23, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Dec 23, 2020 •
edited
Loading

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 23, 2020
@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Dec 23, 2020

Marking as critical as this is only tests and unblocks another PR.

@MikeMcQuaid MikeMcQuaid disabled auto-merge December 23, 2020 13:44
@MikeMcQuaid MikeMcQuaid merged commit d6692d2 into Homebrew:master Dec 23, 2020
@iMichka iMichka deleted the bottle-write-test2 branch December 23, 2020 14:52
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 23, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

+2 more reviewers

@dawidd6 dawidd6 dawidd6 approved these changes

@SeekingMeaning SeekingMeaning SeekingMeaning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iMichka @BrewTestBot @SeekingMeaning @MikeMcQuaid @dawidd6