formula: add deprecation_date and disable_date methods

[Rylan12]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?
• Have you successfully run brew man locally and committed any changes?

---

This PR adds the Formula#deprecation_date and Formula#disable_date methods. These will return the respective dates when they exist. If not, the methods return nil. This is needed for Homebrew/actions#133 and Homebrew/homebrew-core#67386.

I'm marking this as critical because it is blocking those other PRs. Since the PR is a simple change that only adds methods that aren't used in the codebase yet, I don't feel the full 24 hours are needed. However, I will wait to merge until I'm ready to move forward with the other PRs.

[BrewTestBot]

Review period ended.

[MikeMcQuaid]

I'm fine with this but I wonder if as-well/instead it'd be easier for the actions to have this be part of the JSON output? I'd imagine @EricFromCanada would perhaps also use it for formulae.brew.sh. No worries if not (it's not blocking).

[MikeMcQuaid]

Might be nice to have a delegate ... :"self.class" helper method because it's used in a tonne of places (as a follow-up PR).

[Rylan12]

Agreed but I'll opt for the follow-up PR.

[MikeMcQuaid]

Yup, thanks!

[Rylan12]

I'm fine with this but I wonder if as-well/instead it'd be easier for the actions to have this be part of the JSON output?

How would one get JSON information for all formulae in a ruby script? I know that brew info --json returns the JSON output and I could retrieve a ruby hash of the JSON output with formula.to_hash, but I don't think that solution works any better or worse than what I currently have.

Regardless, I think it makes sense to have the deprecation/disable date and reason in the JSON output, so I'll add it. That was Eric and others can use it if they desire.

[MikeMcQuaid]

How would one get JSON information for all formulae in a ruby script? I know that brew info --json returns the JSON output and I could retrieve a ruby hash of the JSON output with formula.to_hash, but I don't think that solution works any better or worse than what I currently have.

I was thinking you might prefer shelling out to brew info --json than a Ruby script. If not: no worries.

[Rylan12]

I was thinking you might prefer shelling out to brew info --json than a Ruby script. If not: no worries.

Is there a significant speed/other benefit to doing that? We're already working in ruby so shelling out just to bring it back into ruby doesn't seem that helpful to me. Plus, speed isn't going to be an issue here. We only need the action to run once a day anyway so if it takes five minutes to run it's not a huge deal.

(I totally get that you're not pushing it I'm just curious why it might be better)

[MikeMcQuaid]

Is there a significant speed/other benefit to doing that? We're already working in ruby so shelling out just to bring it back into ruby doesn't seem that helpful to me.

Nope, thought you might be shelling out from JS.

[Rylan12]

Nope, thought you might be shelling out from JS.

Ah, gotcha! In that case, makes a lot of sense.