bottle --merge: check for all cellars

[iMichka]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?
• Have you successfully run brew man locally and committed any changes?

---

[BrewTestBot]

Review period ended.

[iMichka]

This fixes (on linux):

Error: --keep-old was passed but there are changes in:
cellar: old: "/home/linuxbrew/.linuxbrew/Cellar", new: :"/home/linuxbrew/.linuxbrew/Cellar"

[MikeMcQuaid]

Would be good to have the same thing for these too:

brew/Library/Homebrew/global.rb

Lines 64 to 69 in e69a54d

	HOMEBREW_DEFAULT_PREFIX = "/usr/local"
	HOMEBREW_DEFAULT_REPOSITORY = "#{HOMEBREW_DEFAULT_PREFIX}/Homebrew"
	HOMEBREW_MACOS_ARM_DEFAULT_PREFIX = "/opt/homebrew"
	HOMEBREW_MACOS_ARM_DEFAULT_REPOSITORY = HOMEBREW_MACOS_ARM_DEFAULT_PREFIX
	HOMEBREW_LINUX_DEFAULT_PREFIX = "/home/linuxbrew/.linuxbrew"
	HOMEBREW_LINUX_DEFAULT_REPOSITORY = "#{HOMEBREW_LINUX_DEFAULT_PREFIX}/Homebrew"

[SeekingMeaning]

Should we use these instead?

brew/Library/Homebrew/global.rb

Lines 87 to 89 in e69a54d

	DEFAULT_PREFIX ||= HOMEBREW_DEFAULT_PREFIX
	DEFAULT_REPOSITORY ||= HOMEBREW_DEFAULT_REPOSITORY
	DEFAULT_CELLAR = "#{DEFAULT_PREFIX}/Cellar"

Their initial values seem to be set here:

• https://github.com/Homebrew/brew/blob/master/Library/Homebrew/os/mac/global.rb
• https://github.com/Homebrew/brew/blob/master/Library/Homebrew/os/linux/global.rb

[MikeMcQuaid]

We should check them for every platform so we never set it even if we're running brew bottle on a different platform to the platform it's bottling for (e.g. when merging).

[SeekingMeaning]

Ah, right, I didn't think of that