Skip to content

cmd/list: Remove help text about -l displaying file sizes#10136

Merged
issyl0 merged 1 commit intoHomebrew:masterfrom
issyl0:brew-list-remove-l-option-totals-help-text
Dec 25, 2020
Merged

cmd/list: Remove help text about -l displaying file sizes#10136
issyl0 merged 1 commit intoHomebrew:masterfrom
issyl0:brew-list-remove-l-option-totals-help-text

Conversation

@issyl0
Copy link
Copy Markdown
Member

@issyl0 issyl0 commented Dec 24, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2020-12-25 at 16:05:11 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 24, 2020
@issyl0 issyl0 force-pushed the brew-list-remove-l-option-totals-help-text branch from aabca73 to fc7a397 Compare December 24, 2020 16:17
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @issyl0!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 25, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

- It doesn't work on the `HOMEBREW_CELLAR` dir for some reason, and
  using `du -sh` instead (PR 10131) was an extra call that we don't
  need.
- (I had to edit the man page manually as `brew man` gives me "Broken
  pipe" errors.)
@issyl0 issyl0 force-pushed the brew-list-remove-l-option-totals-help-text branch from fc7a397 to 90868ff Compare December 25, 2020 19:04
@issyl0 issyl0 enabled auto-merge December 25, 2020 19:05
@issyl0 issyl0 merged commit 3f4427e into Homebrew:master Dec 25, 2020
@issyl0 issyl0 deleted the brew-list-remove-l-option-totals-help-text branch December 28, 2020 13:59
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 28, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants