Skip to content

audit: fix prerelease audit#10138

Merged
Rylan12 merged 1 commit intoHomebrew:masterfrom
Rylan12:fix-prerelease-audit
Dec 24, 2020
Merged

audit: fix prerelease audit#10138
Rylan12 merged 1 commit intoHomebrew:masterfrom
Rylan12:fix-prerelease-audit

Conversation

@Rylan12
Copy link
Copy Markdown
Member

@Rylan12 Rylan12 commented Dec 24, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fixes an issue with the GitHub prerelease audit. Previously, this would fail for prereleases that were added to the exception list. Not sure how this slipped through my testing... 🤦

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Dec 24, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Dec 24, 2020

Review period ended.

@Rylan12 Rylan12 enabled auto-merge December 24, 2020 18:38
@Rylan12 Rylan12 changed the title aduit: fix prerelease audit audit: fix prerelease audit Dec 24, 2020
@Rylan12 Rylan12 merged commit 1f80e57 into Homebrew:master Dec 24, 2020
@Rylan12 Rylan12 deleted the fix-prerelease-audit branch December 24, 2020 23:30
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @Rylan12
!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 25, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants