cli/parser: improve name_to_option for some cask args#10139
Closed
Rylan12 wants to merge 1 commit intoHomebrew:masterfrom
Rylan12:fix-cask-arg-names
Closed
cli/parser: improve name_to_option for some cask args#10139Rylan12 wants to merge 1 commit intoHomebrew:masterfrom Rylan12:fix-cask-arg-names
Rylan12 wants to merge 1 commit intoHomebrew:masterfrom
Rylan12:fix-cask-arg-names
Conversation
Contributor
|
Review period will end on 2020-12-25 at 19:18:45 UTC. |
MikeMcQuaid
approved these changes
Dec 25, 2020
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks @Rylan12! I think it'd be nice to update these flags to be consistent with the others eventually, though.
Member
Author
|
Agreed. I'll look into it. |
8 tasks
Member
Author
|
This won't be needed if #10147 is merged, so putting on hold until a decision is made there. |
Contributor
|
Review period ended. |
BrewTestBot
approved these changes
Dec 25, 2020
MikeMcQuaid
approved these changes
Dec 28, 2020
Member
Author
|
#10147 has been merged so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?Follow up to #10133
Previously (note that
--input_methoddiris incorrectly displayed as--input-methoddir):Now (note the correct
--input_methoddirflag is shown):CC @issyl0 and @reitermarkus