Remove :appcast and rename :cask_url to :url.#10141
Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom Dec 25, 2020
Merged
Remove :appcast and rename :cask_url to :url.#10141reitermarkus merged 1 commit intoHomebrew:masterfrom
:appcast and rename :cask_url to :url.#10141reitermarkus merged 1 commit intoHomebrew:masterfrom
Conversation
Contributor
|
Review period will end on 2020-12-25 at 23:52:58 UTC. |
c65a075 to
7f633cc
Compare
Contributor
|
Review period ended. |
BrewTestBot
approved these changes
Dec 25, 2020
Member
Author
|
Marking as critical so we can start using |
samford
approved these changes
Dec 25, 2020
Member
samford
left a comment
There was a problem hiding this comment.
The only other place we use appcast in livecheck is Livecheck#checkable_urls (which collects URLs in a formula/cask to try when there isn't a livecheck block) but we should keep that until appcast is totally gone from casks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?livecheckis a replacement forappcast, so:appcastshould never be needed. The:cask_urlnaming is weird, since theurlis always the cask url.url :urlmay look weird, but at least is consistent withurl :homepage.