Skip to content

Remove :appcast and rename :cask_url to :url.#10141

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:livecheck-url
Dec 25, 2020
Merged

Remove :appcast and rename :cask_url to :url.#10141
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:livecheck-url

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Dec 24, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

livecheck is a replacement for appcast, so :appcast should never be needed. The :cask_url naming is weird, since the url is always the cask url. url :url may look weird, but at least is consistent with url :homepage.

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2020-12-25 at 23:52:58 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 24, 2020
@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Dec 25, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Dec 25, 2020

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 25, 2020
@reitermarkus
Copy link
Copy Markdown
Member Author

Marking as critical so we can start using :url in casks as soon as possible.

Copy link
Copy Markdown
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other place we use appcast in livecheck is Livecheck#checkable_urls (which collects URLs in a formula/cask to try when there isn't a livecheck block) but we should keep that until appcast is totally gone from casks.

@reitermarkus reitermarkus merged commit 5143b86 into Homebrew:master Dec 25, 2020
@reitermarkus reitermarkus deleted the livecheck-url branch December 25, 2020 01:10
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 25, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants