Skip to content

cmd/reinstall: refactor about formula? and cask?.#10174

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
hyuraku:cmd/reinstall_refactor
Dec 31, 2020
Merged

cmd/reinstall: refactor about formula? and cask?.#10174
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
hyuraku:cmd/reinstall_refactor

Conversation

@hyuraku
Copy link
Copy Markdown
Contributor

@hyuraku hyuraku commented Dec 29, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

refactor cmd/reinstall where args checked whether formula? or cask?.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @hyuraku!

@MikeMcQuaid MikeMcQuaid merged commit a7b61c6 into Homebrew:master Dec 31, 2020
@hyuraku hyuraku deleted the cmd/reinstall_refactor branch January 27, 2021 12:32
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants