Merged
Conversation
- move `add_bottle_stanza!` from `Utils::Bottles` to `Utils::AST` - add `replace_bottle_stanza!` - simplify parameters
Contributor
|
Review period will end on 2020-12-30 at 11:53:02 UTC. |
Contributor
|
Review period ended. |
BrewTestBot
approved these changes
Dec 30, 2020
MikeMcQuaid
approved these changes
Dec 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?This is the first round of improvements for the recently-added AST helper functions
add_bottle_stanza!fromUtils::BottlestoUtils::ASTreplace_bottle_stanza!dev-cmd/bottletests verify that this is working@iMichka I know you've been working on the new cellar syntax; please feel free to open a PR and not let this PR be blocking