Skip to content

utils/ast: cleanup#10175

Merged
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:ast-helper-cleanup
Dec 31, 2020
Merged

utils/ast: cleanup#10175
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:ast-helper-cleanup

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

@SeekingMeaning SeekingMeaning commented Dec 29, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This is the first round of improvements for the recently-added AST helper functions

  • Move add_bottle_stanza! from Utils::Bottles to Utils::AST
  • Add replace_bottle_stanza!
    • I have not added tests for this function, but the existing dev-cmd/bottle tests verify that this is working
  • Simplify parameters

@iMichka I know you've been working on the new cellar syntax; please feel free to open a PR and not let this PR be blocking

- move `add_bottle_stanza!` from `Utils::Bottles` to `Utils::AST`
- add `replace_bottle_stanza!`
- simplify parameters
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2020-12-30 at 11:53:02 UTC.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Dec 29, 2020
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@SeekingMeaning SeekingMeaning merged commit acf0ecc into Homebrew:master Dec 31, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 31, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants