cleanup: don't do stale check when passing --prune.#10189
cleanup: don't do stale check when passing --prune.#10189MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:cleanup_faster_prune
Conversation
This speeds up `--prune` fairly considerably. Before: ``` $ hyperfine --warmup 3 'brew cleanup --prune=365' Benchmark #1: brew cleanup --prune=365 Time (mean ± σ): 33.352 s ± 0.654 s [User: 21.684 s, System: 6.458 s] Range (min … max): 31.901 s … 34.096 s 10 runs ``` After: ``` $ hyperfine --warmup 3 'brew cleanup --prune=365' Benchmark #1: brew cleanup --prune=365 Time (mean ± σ): 6.821 s ± 0.186 s [User: 2.225 s, System: 3.926 s] Range (min … max): 6.578 s … 7.178 s 10 runs ``` Closes #10177 Fixes #10172
|
Review period will end on 2021-01-01 at 14:00:34 UTC. |
|
Review period skipped due to |
|
With that merged, the timings for Intel Big Sur runners have gone from:
to
I'd have to check what is still taking so long. Even with thousands of files, getting |
I don't think the ARM runner is a good comparison for various reasons:
|
This speeds up
--prunefairly considerably.Before:
After:
Closes #10177
Fixes #10172