Skip to content

cmd/update-report: fix to show new tag#10194

Merged
Rylan12 merged 1 commit intoHomebrew:masterfrom
hyuraku:cmd/update-report_fix-show-new-tag
Jan 1, 2021
Merged

cmd/update-report: fix to show new tag#10194
Rylan12 merged 1 commit intoHomebrew:masterfrom
hyuraku:cmd/update-report_fix-show-new-tag

Conversation

@hyuraku
Copy link
Copy Markdown
Contributor

@hyuraku hyuraku commented Jan 1, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

fix cmd/update-report to show new correct tag. When I executed brew update, new_tag was backup/remove-popen-read-20-00-21, but I expected it was 2.7.1.

git -C /usr/local/Homebrew tag --list --sort=-version:refname "*.*"
 $ git -C /usr/local/Homebrew tag --list --sort=-version:refname "*.*"
2.7.1
2.7.0
2.6.2
2.6.1
2.6.0
2.5.12
--< omit >--
git -C /usr/local/Homebrew tag --list --sort=-version:refname
$ git -C /usr/local/Homebrew tag --list --sort=-version:refname
backup/remove-popen-read-20-00-21
backup/remove-popen-read-19-56-50
backup/gpg-verification-01-53-16
backup/days-19-30-23
backup/days-03-02-59
backup/days-03-02-52
backup/create-cache-00-29-47
backup/brew-cask-style-14-54-55
backup/activesupport-23-38-09
2.7.1
2.7.0
--< omit >--

@Rylan12
Copy link
Copy Markdown
Member

Rylan12 commented Jan 1, 2021

Thanks, @hyuraku!

@Rylan12 Rylan12 merged commit 1af8203 into Homebrew:master Jan 1, 2021
@hyuraku hyuraku deleted the cmd/update-report_fix-show-new-tag branch January 28, 2021 01:34
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 28, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants