Skip to content

zsh/completions: add_cask_options#10200

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
hyuraku:zsh/completions_add_cask_options
Jan 5, 2021
Merged

zsh/completions: add_cask_options#10200
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
hyuraku:zsh/completions_add_cask_options

Conversation

@hyuraku
Copy link
Copy Markdown
Contributor

@hyuraku hyuraku commented Jan 2, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

add cask options to commands( info, audit and install ) in zsh/completions
related #10123

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Might be nice to have a brew casks command like brew formulae in future.

@hyuraku hyuraku force-pushed the zsh/completions_add_cask_options branch from 06306ca to 90ff41f Compare January 5, 2021 06:54
@MikeMcQuaid MikeMcQuaid merged commit 70a7603 into Homebrew:master Jan 5, 2021
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @hyuraku!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 5, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 5, 2021
@hyuraku hyuraku deleted the zsh/completions_add_cask_options branch April 16, 2021 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants