checksum: simplify, use only sha256

[iMichka]

We use only one sha type right now.

Needed for #10186

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?
• Have you successfully run brew man locally and committed any changes?

---

[BrewTestBot]

Review period will end on 2021-01-08 at 07:54:12 UTC.

[iMichka]

There are still a few places that call hash_type and I need to check these. I pushed a few more changes.

[MikeMcQuaid]

Looks good, nice cleanup @iMichka!

brew/Library/Homebrew/exceptions.rb

Lines 627 to 643 in db0b69a

	# Raised by {Pathname#verify_checksum} when verification fails.
	class ChecksumMismatchError < RuntimeError
	attr_reader :expected, :hash_type
	def initialize(path, expected, actual)
	@expected = expected
	@hash_type = expected.hash_type.to_s.upcase
	super <<~EOS
	#{@hash_type} mismatch
	Expected: #{Formatter.success(expected.to_s)}
	Actual: #{Formatter.error(actual.to_s)}
	File: #{path}
	To retry an incomplete download, remove the file above.
	EOS
	end
	end

still needs to be updated, I think, but once that's done and CI is 🟢 I'm 👍🏻 to 🚢

[iMichka]

All green for me, except the delegate change that I am not able to make work.

[SeekingMeaning]

I would recommend this:

    def sha256(val)
      stable.sha256(val)
    end

Or otherwise using delegate: SeekingMeaning@9faf25527

[SeekingMeaning]

Probably should try to add as few :sha256 symbols as possible; we can delete the hash_type variable in bump-formula-pr: SeekingMeaning@7c248d26a

Currently looking into def checksums in software_spec.rb—we might be able to return an array instead of a hash that only has :sha256 as a key (Edit: See SeekingMeaning@c01b1cc80)

[iMichka]

bump-formula-pr

Done

[SeekingMeaning]

(You missed the hash_type.blank? → old_hash.blank? change)

[SeekingMeaning]

I would also recommend SeekingMeaning@c01b1cc80 but I'm not familiar with all uses of BottleSpecification#checksums so 👍 from me

[iMichka]

The checksums are coming from https://github.com/Homebrew/brew/pull/10247/files#diff-bb40db554b6955f972e80737c5883dafef80ffe19b09e0ad1ceeea1cb776f694L425-L439 for this part of the code. This should be fine. This is a part of code I will rework with my follow up PRs as the logic is going to change there.

[BrewTestBot]

Review period ended.

[MikeMcQuaid]

Thanks for the cleanup @iMichka!