Make HOMEBREW_PREFIX/Caskroom the default.

[reitermarkus]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew tests with your changes locally?

---

Fixes Homebrew/homebrew-cask#24610.

[MikeMcQuaid]

@reitermarkus May also be worth tweaking https://github.com/Homebrew/brew/blob/master/Library/Homebrew/cmd/update-report.rb#L234-L239. Happy to merge this once we have one job with 👍 to avoid waiting for coverage completion.

[MikeMcQuaid]

Also: will this break any symlinks?

[reitermarkus]

I'm not sure about tweaking update-report.rb, because if the Caskroom isn't moved to the new repository first, there won't be a reference to it.

[MikeMcQuaid]

It feels pretty odd to move it and then move it back to the same location?

[MikeMcQuaid]

This is only run if HOMEBREW_REPOSITORY and HOMEBREW_PREFIX are both /usr/local so it's a no-op and can be removed.

[MikeMcQuaid]

These will always be the same path.

[reitermarkus]

Ah, ok, will remove this whole section then.

[reitermarkus]

Also: will this break any symlinks?

It might. But it will probably fix more symlinks than it breaks, since the move to /usr/local/Homebrew/Caskroom broke all links pointing to /usr/local/Caskroom.

[jawshooah]

@reitermarkus commented on Sep 19, 2016, 10:16 AM EDT:

Also: will this break any symlinks?

It might. But it will probably fix more symlinks than it breaks, since the move to /usr/local/Homebrew/Caskroom broke all links pointing to /usr/local/Caskroom.

It will certainly break symlinks, but I'm not sure how it would fix any.

[reitermarkus]

/usr/local/Caskroom was migrated to /usr/local/Homebrew/Caskroom with the migration of the Homebrew repo to /usr/local/Homebrew, so all symlinks would be broken if we left the Caskroom at /usr/local/Homebrew/Caskroom.

[jawshooah]

Ah, sorry, read your comment too fast and thought you were talking about the earlier migration from /opt/homebrew-cask/Caskroom to /usr/local/Caskroom.

[codecov-io]

Current coverage is 81.76% (diff: 100%)

Merging #1025 into master will decrease coverage by 1.52%

@@             master      #1025   diff @@
==========================================
  Files           340        340          
  Lines         14109      14390   +281   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          11751      11766    +15   
- Misses         2358       2624   +266   
  Partials          0          0          

Powered by Codecov. Last update 3ffb9a2...c0cc703