Skip to content

Docs: non-cask binaries are not overwritten by --force#10254

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
vitorgalvao:casks-no-overwrite-symlink
Jan 8, 2021
Merged

Docs: non-cask binaries are not overwritten by --force#10254
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
vitorgalvao:casks-no-overwrite-symlink

Conversation

@vitorgalvao
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This was decided in August but recently we had another issue because of it. Understandably, some people will expect --force to mean “trample everything”, so we should document when that isn’t the case.

@vitorgalvao vitorgalvao added documentation Documentation changes cask Homebrew Cask labels Jan 7, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-01-08 at 21:26:39 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 7, 2021
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 8, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 8, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit da34993 into Homebrew:master Jan 8, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 11, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cask Homebrew Cask critical Critical change which should be shipped as soon as possible. documentation Documentation changes outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants