Skip to content

Only select Sparkle items for macOS.#10273

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:sparkle-macos
Jan 12, 2021
Merged

Only select Sparkle items for macOS.#10273
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:sparkle-macos

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Apparently Sparkle appcasts can contain releases for other platforms, we only use this strategy for casks as far as I'm aware of, so exclude other platforms if the os attribute is specified.

Fixes CI failure in Homebrew/homebrew-cask#97558.

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-01-12 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 9, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 12, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@reitermarkus reitermarkus merged commit e84939c into Homebrew:master Jan 12, 2021
@reitermarkus reitermarkus deleted the sparkle-macos branch January 12, 2021 00:47
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 11, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants