cmd/cleanup: add description about all to --prune#10301
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Jan 22, 2021
Merged
cmd/cleanup: add description about all to --prune#10301MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Conversation
MikeMcQuaid
reviewed
Jan 12, 2021
Library/Homebrew/cmd/cleanup.rb
Outdated
Comment on lines
25
to
26
Member
There was a problem hiding this comment.
Suggested change
| description: "Remove all cache files older than specified <days>."\ | |
| "if you want to remove the all, set 'all'" | |
| description: "Remove all cache files older than specified <days>. "\ | |
| "If you want to remove everything, use `--prune=all`." |
b6f28e9 to
9684f5a
Compare
Contributor
Author
|
@MikeMcQuaid |
MikeMcQuaid
approved these changes
Jan 22, 2021
MikeMcQuaid
reviewed
Jan 22, 2021
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Sorry, just noticed the missing space/capital here. Sorry again for the delay in rereview!
Library/Homebrew/cmd/cleanup.rb
Outdated
Comment on lines
25
to
26
Member
There was a problem hiding this comment.
Suggested change
| description: "Remove all cache files older than specified <days>."\ | |
| "if you want to remove everything, use `--prune=all`." | |
| description: "Remove all cache files older than specified <days>. "\ | |
| "If you want to remove everything, use `--prune=all`." |
Contributor
Author
There was a problem hiding this comment.
Thank you for the review. I fix it right now.
9684f5a to
b4df0d5
Compare
MikeMcQuaid
approved these changes
Jan 22, 2021
Member
|
Thanks again @hyuraku! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?add description about
allto--prune=incmd/cleanup. Because only the error message tells aboutall.