Skip to content

cmd/cleanup: add description about all to --prune#10301

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
hyuraku:cmd/cleanup_add_desc_about_all_to_prune
Jan 22, 2021
Merged

cmd/cleanup: add description about all to --prune#10301
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
hyuraku:cmd/cleanup_add_desc_about_all_to_prune

Conversation

@hyuraku
Copy link
Copy Markdown
Contributor

@hyuraku hyuraku commented Jan 12, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

add description about all to --prune=in cmd/cleanup. Because only the error message tells about all.

@hyuraku hyuraku changed the title cmd/cleanup: add desc about all to --prune cmd/cleanup: add description about all to --prune Jan 12, 2021
Comment on lines 25 to 26
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Remove all cache files older than specified <days>."\
"if you want to remove the all, set 'all'"
description: "Remove all cache files older than specified <days>. "\
"If you want to remove everything, use `--prune=all`."

@hyuraku hyuraku force-pushed the cmd/cleanup_add_desc_about_all_to_prune branch 3 times, most recently from b6f28e9 to 9684f5a Compare January 18, 2021 14:39
@hyuraku
Copy link
Copy Markdown
Contributor Author

hyuraku commented Jan 21, 2021

@MikeMcQuaid
Could you review this again?

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed the missing space/capital here. Sorry again for the delay in rereview!

Comment on lines 25 to 26
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Remove all cache files older than specified <days>."\
"if you want to remove everything, use `--prune=all`."
description: "Remove all cache files older than specified <days>. "\
"If you want to remove everything, use `--prune=all`."

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. I fix it right now.

@hyuraku hyuraku force-pushed the cmd/cleanup_add_desc_about_all_to_prune branch from 9684f5a to b4df0d5 Compare January 22, 2021 11:54
@MikeMcQuaid MikeMcQuaid merged commit 2268e77 into Homebrew:master Jan 22, 2021
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @hyuraku!

@hyuraku hyuraku deleted the cmd/cleanup_add_desc_about_all_to_prune branch January 27, 2021 12:32
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants