Skip to content

patch: delete legacy code#10318

Merged
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:patch-legacy-cleanup
Jan 15, 2021
Merged

patch: delete legacy code#10318
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:patch-legacy-cleanup

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

SoftwareSpec#add_legacy_patches and Patch#normalize_legacy_patches were added almost 6 years ago; let's delete them

See commit 665b14c

$ grep -r 'normalize_legacy_patches' Library/Homebrew
./software_spec.rb:    list = Patch.normalize_legacy_patches(list)
./patch.rb:  def self.normalize_legacy_patches(list)
$ grep -r 'add_legacy_patches' Library/Homebrew
./software_spec.rb:  def add_legacy_patches(list)
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

SoftwareSpec#add_legacy_patches and Patch#normalize_legacy_patches
were added almost 6 years ago; let's delete them

See commit 665b14c

```
$ grep -r 'normalize_legacy_patches' Library/Homebrew
./software_spec.rb:    list = Patch.normalize_legacy_patches(list)
./patch.rb:  def self.normalize_legacy_patches(list)
```

```
$ grep -r 'add_legacy_patches' Library/Homebrew
./software_spec.rb:  def add_legacy_patches(list)
```
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-01-15 at 02:44:38 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 14, 2021
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks! Always nice to 🔥 💀 code.

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 15, 2021
@SeekingMeaning SeekingMeaning merged commit 053ca17 into Homebrew:master Jan 15, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 15, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants