Skip to content

dev-cmd/man: Completely remove --link#10350

Merged
dawidd6 merged 1 commit intoHomebrew:masterfrom
issyl0:brew-man-remove-link-flag
Jan 19, 2021
Merged

dev-cmd/man: Completely remove --link#10350
dawidd6 merged 1 commit intoHomebrew:masterfrom
issyl0:brew-man-remove-link-flag

Conversation

@issyl0
Copy link
Copy Markdown
Member

@issyl0 issyl0 commented Jan 17, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

  • This was deprecated in ec75fbc in 2016! 🗝️ 🧓🏻 :dusty_stick:

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-01-19 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 17, 2021
- This was deprecated in ec75fbc in 2016!
@dawidd6 dawidd6 force-pushed the brew-man-remove-link-flag branch from ee85c93 to a0f3545 Compare January 17, 2021 23:57
@issyl0
Copy link
Copy Markdown
Member Author

issyl0 commented Jan 18, 2021

Ah, yes, the man page code has a man page. ♻️ Thanks @dawidd6!

@MikeMcQuaid
Copy link
Copy Markdown
Member

Nice catch @issyl0!

@dawidd6 dawidd6 enabled auto-merge January 18, 2021 14:47
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 19, 2021
@dawidd6 dawidd6 merged commit 1525350 into Homebrew:master Jan 19, 2021
@dtrodrigues dtrodrigues mentioned this pull request Jan 19, 2021
8 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 19, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants