rubocop: require braces for Sorbet sig#10351
Conversation
|
Review period will end on 2021-01-19 at 06:49:41 UTC. |
MikeMcQuaid
left a comment
There was a problem hiding this comment.
I prefer this style, too, but I think as long as it's consistent one way or the other I don't have strong views. It seems this is the predominant style so far.
b12c11f to
fbafaff
Compare
There was a problem hiding this comment.
Just to add another voice:
I agree this makes sense. I definitely prefer the one-line signatures (when they're possible) which look much better with braces, so it makes sense to choose braces as The One Way.
The only thing I'd say is that it can sometimes be confusing to ruby beginners (at least, it was for me) what a block is and the fact that braces and do end are the same, so adding inconsistency on that front might be a concern. Probably not a major one, though, because most people who aren't already comfortable probably won't care much about that, so I'd say 👍 to this change.
|
Review period ended. |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?I think this is more readable
(Should we have a vote of 👍 or 👎?)