utils/curl: use specs when checking http content problems#10402
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Jan 25, 2021
Rylan12:audit-url-spec-fix
Merged
utils/curl: use specs when checking http content problems#10402MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Rylan12:audit-url-spec-fix
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Rylan12:audit-url-spec-fix
Conversation
Contributor
|
Review period will end on 2021-01-26 at 00:00:00 UTC. |
MikeMcQuaid
approved these changes
Jan 25, 2021
Contributor
|
Review period skipped due to |
BrewTestBot
approved these changes
Jan 25, 2021
Member
|
Thanks again @Rylan12! |
|
Great work, @Rylan12! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?See Homebrew/discussions#576
Currently, specs passed to the
urlmethod are passed tocurlwhen fetching the resource but aren't passed tocurlwhen auditing the resource's url. For example, the user who opened Homebrew/discussions#576 needed to use the--referrerflag incurl. That meant thatbrew audit --onlinewas failing even though the url was reachable when actually runningbrew install.This PR passes those specs on to
Utils::Curl.curl_check_http_contentto ensure that the check will pass in situations like these.