Skip to content

Fix zsh completions for upgrade and reinstall#10411

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
muneebmahmed:fix-zsh-completion
Jan 25, 2021
Merged

Fix zsh completions for upgrade and reinstall#10411
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
muneebmahmed:fix-zsh-completion

Conversation

@muneebmahmed
Copy link
Copy Markdown
Contributor

@muneebmahmed muneebmahmed commented Jan 25, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

#10410 fixed my previous issue #10409, however it also resulted in the upgrade completion to list every cask, not just the outdated or installed ones. I noticed the same behavior for brew reinstall as well. This fixes those completions to only show installed/outdated casks.

I think this PR might become unnecessary due to #10403, but I created this one anyway in case that one does not get merged soon.

@MikeMcQuaid MikeMcQuaid merged commit 26df5e0 into Homebrew:master Jan 25, 2021
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @muneebmahmed!

@muneebmahmed muneebmahmed deleted the fix-zsh-completion branch January 29, 2021 08:17
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 1, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants