Fix zsh completions for upgrade and reinstall#10411
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Jan 25, 2021
Merged
Fix zsh completions for upgrade and reinstall#10411MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Conversation
MikeMcQuaid
approved these changes
Jan 25, 2021
Member
|
Thanks again @muneebmahmed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?#10410 fixed my previous issue #10409, however it also resulted in the
upgradecompletion to list every cask, not just the outdated or installed ones. I noticed the same behavior forbrew reinstallas well. This fixes those completions to only show installed/outdated casks.I think this PR might become unnecessary due to #10403, but I created this one anyway in case that one does not get merged soon.