Skip to content

named_args_spec: add tests for unreadable formulae/casks#10422

Merged
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:named-args-unreadable-tests
Jan 27, 2021
Merged

named_args_spec: add tests for unreadable formulae/casks#10422
SeekingMeaning merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:named-args-unreadable-tests

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Follow-up to #10405

I was going to include this in a different PR, but I thought I should first open this one, where I'm only adding tests. Once this is merged, the intent behind the PR I plan open will hopefully be more clear

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-01-27 at 02:48:14 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 26, 2021
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 ❤️

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 27, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@SeekingMeaning SeekingMeaning merged commit bd7a660 into Homebrew:master Jan 27, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants