Skip to content

cask/audit: disallow new cask to have token in tap_migrations.json#10428

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:cask-reverse-migration
Jan 27, 2021
Merged

cask/audit: disallow new cask to have token in tap_migrations.json#10428
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:cask-reverse-migration

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This audit already exists for formulae (but not for casks): https://github.com/Homebrew/brew/blob/master/Library/Homebrew/formula_auditor.rb#L688-L699

Related: Homebrew/homebrew-cask#98719

@SeekingMeaning SeekingMeaning added the cask Homebrew Cask label Jan 26, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-01-27 at 09:20:43 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 26, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Jan 27, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @SeekingMeaning!

@MikeMcQuaid MikeMcQuaid merged commit 03c861b into Homebrew:master Jan 27, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cask Homebrew Cask outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants