Skip to content

Autoformat YAML files#10429

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:yamllint
Jan 27, 2021
Merged

Autoformat YAML files#10429
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:yamllint

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Jan 26, 2021

Extracted the .rubocop_todo.yml change from #10397 so thought I'd do this to all committed (non-vendor) YAML files.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 26, 2021
Merged
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jan 26, 2021

Review period will end on 2021-01-27 at 10:01:40 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 26, 2021
@MikeMcQuaid
Autoformat YAML files
92d107d 
Extracted the `.rubocop_todo.yml` change from #10397 so thought I'd do
this to all committed (non-vendor) YAML files.
Rylan12
Rylan12 approved these changes Jan 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Rylan12 Rylan12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any change brew style can check for this?

I guess we probably don't have a yaml checker so this might be too much work for not enough benefit

@MikeMcQuaid
Copy link
Copy Markdown
Member Author

MikeMcQuaid commented Jan 26, 2021

Is there any change brew style can check for this?

I guess we probably don't have a yaml checker so this might be too much work for not enough benefit

Yeh, that was my thought too.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 27, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jan 27, 2021

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit 10a5434 into Homebrew:master Jan 27, 2021
@MikeMcQuaid MikeMcQuaid deleted the yamllint branch January 27, 2021 12:15
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeMcQuaid @BrewTestBot @Rylan12