Skip to content

Update fish completions to satisfy brew man#10442

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Rylan12:fish-completions-follow-up
Jan 28, 2021
Merged

Update fish completions to satisfy brew man#10442
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Rylan12:fish-completions-follow-up

Conversation

@Rylan12
Copy link
Copy Markdown
Member

@Rylan12 Rylan12 commented Jan 27, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Follow up to #10431. Between creation and merge some command descriptions were changed. I didn't do a final rebase so brew man is now failing. This PR is a quick fix to let CI pass.

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Jan 27, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period skipped due to critical label.

@Rylan12 Rylan12 enabled auto-merge January 27, 2021 22:55
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period skipped due to critical label.

@Rylan12
Copy link
Copy Markdown
Member Author

Rylan12 commented Jan 28, 2021

Looks like tests are failing consistently here. Not sure why as they shouldn't be affected by this PR. Unfortunately, this PR is also blocking CI from passing on the master branch. I will continue to investigate but I'm not super optimistic as I can't seem to reproduce these errors locally.

Worst case, I can temporarily skip these tests to get passing CI. I'd rather not do this, though.

Edit: trying again because I can't think of anything else to do. I have no issues running this locally.

@Rylan12 Rylan12 disabled auto-merge January 28, 2021 02:34
@Rylan12 Rylan12 closed this Jan 28, 2021
@Rylan12 Rylan12 reopened this Jan 28, 2021
@Rylan12
Copy link
Copy Markdown
Member Author

Rylan12 commented Jan 28, 2021

Okay, I'm at a loss. Any ideas or should I just go ahead and skip the test for now?

Edit: I tried increasing the timeout for this test. Let's see if this works before skipping.

Okay, now nothing's running. Maybe it's a GitHub actions issue? I'm going to take a break and I'll check back later to see how this is going.

@Rylan12
Copy link
Copy Markdown
Member Author

Rylan12 commented Jan 28, 2021

Yep, looks like GitHub's the culprit here: https://www.githubstatus.com/incidents/tf9v5jjmq2lg

@MikeMcQuaid MikeMcQuaid merged commit fa0dd54 into Homebrew:master Jan 28, 2021
@Rylan12 Rylan12 deleted the fish-completions-follow-up branch January 28, 2021 13:48
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 28, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants